https://bugzilla.redhat.com/show_bug.cgi?id=2051055 Mark E. Fuller <mark.e.fuller@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mark.e.fuller@xxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |mark.e.fuller@xxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Mark E. Fuller <mark.e.fuller@xxxxxx> --- On initial review, there are two issues that get flagged: - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages Some additional things: -the devel package should have "Requires: %{name}%{?_isa} = %{version}-%{release}" -are tests being run? I see no %check section in the spec file, but a "tests" directory in the source code: please add this section and run tests if applicable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2051055 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
