https://bugzilla.redhat.com/show_bug.cgi?id=2048456 --- Comment #20 from Parag AN(पराग) <panemade@xxxxxxxxx> --- If upstream follows correct way of development, tagging and release then forge macros are also very much simpler. 1) The way we write tag is just tagged value not complete "refs/tags/v3.0.2". But this is optional as you are using commit hash way to fetch upstream tarball from github. 2) You need to write Source0 as Source0: https://github.com/mitradranirban/fonts-mukti/archive/%{commit}/%{name}-%{shortcommit}.tar.gz 3) It appears as suggested in my previous comment, you have not fixed license tag. Use %global fontlicense GPLv3+ with exceptions 4) Also when you write SPEC file, Good to use empty characters are space character not tabs to separate two consecutive words. Currently it seems you got fbf-mukti-fonts.spec:20: W: mixed-use-of-spaces-and-tabs (spaces: line 10, tab: line 20) -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2048456 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
