https://bugzilla.redhat.com/show_bug.cgi?id=2050295 --- Comment #9 from Parag AN(पराग) <panemade@xxxxxxxxx> --- 1) You need to use either one as suggested in packaging guidelines. Either commit or tag. If you want to use commit, then gittag line becomes optional. 2) If we use the commit approach then let's check if Source0: is downloadable. wget https://github.com/mitradranirban/font-uniol/fd2431cc7661f68e52d2b32598d720f60ba735ff.tar.gz --2022-02-06 05:53:27-- https://github.com/mitradranirban/font-uniol/fd2431cc7661f68e52d2b32598d720f60ba735ff.tar.gz Resolving github.com (github.com)... 13.234.176.102 Connecting to github.com (github.com)|13.234.176.102|:443... connected. HTTP request sent, awaiting response... 404 Not Found 2022-02-06 05:53:28 ERROR 404: Not Found. This mean you have not followed the way github Source used to get downloaded as defined in that guidelines page. Use Source0: https://github.com/mitradranirban/font-uniol/archive/%{commit}/%{name}-%{shortcommit}.tar.gz 3) After you do above fixes, I am able to build this package now. Next we need to check rpmlint on generated srpm and rpms [~/rpmbuild]$ rpmlint SRPMS/uniol-fonts-1.0.1-3.fc35.src.rpm RPMS/noarch/uniol-fonts-1.0.1-3.fc35.noarch.rpm uniol-fonts.spec: E: specfile-error error: %changelog entries must start with * uniol-fonts.noarch: E: no-changelogname-tag uniol-fonts.src: E: no-changelogname-tag uniol-fonts.spec:49: W: macro-in-%changelog %forgemeta uniol-fonts.spec:49: W: macro-in-%changelog %forgesource uniol-fonts.spec:62: W: macro-in-%changelog %forgemacro For every macro you write in any Changelog entry you need to add one more % character, hence your %forgemeta becomes %%forgemeta This will prevent to expand that macros in changelog entry when package is built. You forgot to start each changelog entry with "*" character. Also, After you fixed upstream, I can now successfully used forge macros to create this package. But as you find alternate method useful, you can keep it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2050295 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
