https://bugzilla.redhat.com/show_bug.cgi?id=2051008 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial spec review: * Is the ffmpeg_clean_sources.sh script safe to run on an already cleaned tarball? If it is, it'd be good to run against the sources in %prep, like we do for OpenSSL. * fedora-review complains about the Source0 mismatch. Looking at other packages with cleaned sources (chromium, openssl), the Source0 doesn't have a URL when using cleaned sources. Please make a similar adjustment here. * This package is missing a BR on gcc and make, which are required for this package to build. > CFLAGS="%{optflags}" \ > %if %{with lto} > LDFLAGS="%{_lto_cflags}" \ > %endif This can be simplified to "%set_build_flags", which handles this logic properly for you (as you disable LTO further up in the spec properly) > --optflags="%{optflags}" \ > --extra-cflags="%{optflags}" \ Is this actually needed? If so, it probably makes sense to use "%{build_cflags}" for --extra-cflags, though. > %{_libdir}/libavcodec.so.%{av_codec_soversion}* > %{_libdir}/libavdevice.so.%{av_device_soversion}* > %{_libdir}/libavfilter.so.%{av_filter_soversion}* > %{_libdir}/libavformat.so.%{av_format_soversion}* > %{_libdir}/libavutil.so.%{av_util_soversion}* > %{_libdir}/libpostproc.so.%{postproc_soversion}* > %{_libdir}/libswresample.so.%{swresample_soversion}* > %{_libdir}/libswscale.so.%{swscale_soversion}* It would be better to use "{,.*}" instead of "*" here, since that ensures that we don't get odd matches for soversions (it's more explicit). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2051008 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
