https://bugzilla.redhat.com/show_bug.cgi?id=2040728 --- Comment #10 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > # Following gets removed on next GA release > mkdir -p %{buildroot}/%{_datadir}/licenses/%{name} > mv %{buildroot}/%{_datadir}/%{name}/COPYING %{buildroot}/%{_datadir}/licenses/%{name}/COPYING This is not needed. The %license macro works as follows: - if the path is absolute, it is treated as pointing to a file in the buildroot - if the path is relative, it is treated as pointing to a file in the build directory, which is then copied where needed In other words, you do not need to copy the file to "%{buildroot}%{_datadir}/licenses/%{name}" yourself. The "%license app/COPYING" line will take care of that for you. > %package docs Sorry, it just occurred to me that the Packaging Guidelines say this should be "doc", not "docs". (i.e. singular, without the "s") https://docs.fedoraproject.org/en-US/packaging-guidelines/#_separate_documentation_packages > %files > ... > %{_datadir}/%{name}/applications > %{_datadir}/%{name}/logo.bmp > %{_datadir}/%{name}/xdg-open > %{_datadir}/%{name}/xtrkcad-setup > %{_datadir}/%{name}/xtrkcad.tip > %{_datadir}/%{name}/xtrkcad.upd > %{_datadir}/%{name}/xtrkcad.xtq > > %files docs > %{_datadir}/%{name}/demos > %{_datadir}/%{name}/examples > %{_datadir}/%{name}/html > %{_datadir}/%{name}/params This makes the %{_datadir}/%{name} directory not belong to any package. There are two ways you can fix this: 1. Add "%dir %{_datadir}/%{name}" to the main package. This makes the package own the directory, but not the files within. 2. Add "%{_datadir}/%{name}" to the main package to make it own the directory and the files within, and then use "%exclude %{_datadir}/%{name}/demos" to specify exceptions. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ Also - is the "params" directory not needed by the application? The program *must* be able to run properly without the -doc package installed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2040728 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
