[Bug 2050295] Review Request: uniol-fonts - Unicode compliant Open source Ol Chiki or Ol Cemet font

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2050295



--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
1) disttag is not present. You need to write
   Release:   1
   as
   Release:   1%{?dist}

   Read https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/

2) The Source0 line is not the way it should be written. 
   Read
https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_using_forges_hosted_revision_control
   You need to use forge macros then it will be easy to write as
   Source0:  %{forgesource}   

3) you should release the tarball in upstream. This is not good to add tarball
as a file in upstream git repository.
   Forge macros usage need commit or tag to be written in SPEC file.


4) Avoid adding too many empty lines


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2050295
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux