https://bugzilla.redhat.com/show_bug.cgi?id=2048007 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |michel@xxxxxxxxxxxxxxx Flags| |fedora-review+ Status|NEW |POST CC| |michel@xxxxxxxxxxxxxxx --- Comment #1 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- if you need the fonts for tests you can probably just list them as additional sources, then check them into the lookaside cache with 'fedpkg new-sources'. That opens another can of worms though - what licenses are the fonts under? I don't see any license declaration for them. So probably best to leave them off for now. You might want to consider selectively marking the tests that need fonts as #[ignore], that way the rest can run. But either way, not a blocker. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - ! test suite is run and all unit tests pass => explanation provided - latest version of the crate is packaged - license matches upstream specification (ASL 2.0) and is acceptable for Fedora - license files are included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add package to rust-sig with "commit" access - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2048007 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
