https://bugzilla.redhat.com/show_bug.cgi?id=2049379 --- Comment #7 from Kyle Knapp <kyleknap@xxxxxxxxxx> --- (In reply to Neal Gompa from comment #6) > (In reply to Kyle Knapp from comment #4) > > Thanks Neal! I created a PR in the repository where David and I are > > developing the specfiles right now: > > https://github.com/davdunc/awscli-2-rpm/pull/30. It should have addressed > > all of the feedback and David will send a new link to the updated specfile > > and srpm. > > > > It looks like most of this feedback is applicable to the other aws-c-* > > modules so we will make sure to update those. I did have one question about > > the cmake configs comment. When I was building all of the aws-c-* modules > > together (i.e. using rpmbuild or mock), cmake seemed to be able to > > successfully locate and build against the various aws-c-* modules even > > though they used the path %{_libdir}/<name>/cmake/ for installing their > > configs. Even in the cmake documentation: > > https://cmake.org/cmake/help/latest/command/find_package.html#config-mode- > > search-procedure, it seems to indicate that cmake should be able to find the > > configs under %{_libdir}/<name>/cmake/. What commands/steps do you need to > > run to tell that the %{_libdir}/<name>/cmake pattern is not working > > correctly? Or is it more for consistency that all cmake config files need to > > be under %{_libdir}/cmake/? I added a patch so that the library does install > > it in the %{_libdir}/cmake/aws-c-common path, and we will have to add > > similar patches to the rest of the aws-c-* modules. So I'm trying to fully > > understand it before making those updates. > > The issue is that the dependency generator can't find %{_libdir}/*/cmake > modules, only %{_libdir}/cmake/* modules. And depending on how CMake is > configured, it may not be able to find %{_libdir}/*/cmake modules (though it > does by default). Ah that makes sense. David posted the updated specfile and srpm that included that update. We'll also go ahead and make sure the rest of the aws-c-* reviews use this path pattern for the cmake configs. Thanks! -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2049379 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
