[Bug 2049379] Review Request: aws-c-common - Core c99 package for AWS SDK for C

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2049379



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> %files
> %license LICENSE
> %doc README.md
>
> %files libs
> %{_libdir}/libaws-c-common.so
> %{_libdir}/libaws-c-common.so.1
> %{_libdir}/libaws-c-common.so.1.0.0

These two files sections can be collapsed into a single "%files libs" section.
Additionally, you can simplify the library filenames into a single:

> %{_libdir}/libaws-c-common.so.1{,.*}

And "%{_libdir}/libaws-c-common.so" needs to be in the devel subpackage.

Finally, with these changes, the libs subpackage shouldn't depend on an empty
main package that isn't going to be made, so:

> Requires:       %{name}%{?_isa} = %{version}-%{release}

should be dropped.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2049379
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux