Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libfprint - Tool kit for fingerprint scanner https://bugzilla.redhat.com/show_bug.cgi?id=398081 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-12-03 01:15 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4ca061913b1fe9ad8c16ec71d9f39a9f libfprint-0.0.4.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + Compiler flags used correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + libfprint.pc file present. + -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + ldconfig scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Package libfprint-0.0.4-3.fc9 -> Provides: libfprint.so.0 Requires: libMagick.so.10 libWand.so.10 libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4) libfprint.so.0 libglib-2.0.so.0 libm.so.6 libm.so.6(GLIBC_2.0) libusb-0.1.so.4 + Package libfprint-devel-0.0.4-3.fc9 -> Requires: libfprint = 0.0.4-3.fc9 libfprint.so.0 pkgconfig + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review