https://bugzilla.redhat.com/show_bug.cgi?id=2034758 --- Comment #5 from Mattia Verga <mattia.verga@xxxxxxxxxxxxxx> --- Sorry for the late reply, I didn't see you email. Before posting a full review from fedora-review, I have some notices to do: - License: BSD-3-Clause-LBNL I see there's a "LICENSE-APACHE-2.0" which refers to code contained in one file. I think this license too should be listed. Also, I see a "COPYRIGHT.md" file which says "All rights reserved" (the same spec file contains such lines)... the "All rights reserved" is not acceptable. - Provides: singularity Obsoletes: singularity < 3.9 Conflicts: singularity Please list proper Provides/Obsoletes https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages The "Conflicts" tag is not required, in fact it is discouraged: https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/ - Source: %{name}-%{package_version}.tar.gz Source1: go1.16.12.src.tar.gz Where are these sources come from? Can't you provide a full URL for sources? Also, and that's my greatest doubt after the license, if I'm correct you're building the package using a bundled Go toolchain? I will ask on the Fedora mailing list if it is possible at all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2034758 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
