https://bugzilla.redhat.com/show_bug.cgi?id=2048158 --- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> --- Initial review notes: Package was generated through rust2rpm, simplifying the review considerably. - Conforms to packaging guidelines (rust2rpm generated spec) - license correct and valid - executable produced with correct binary subpackage - builds and installs There are a couple of issues, though: - meson_options.txt is captured as a doc file for some reason? For what purpose? - The primary build script is actually Meson and not Cargo, and some files are only installed through Meson. Please take a look at this and see if there's something to adjust here... -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2048158 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
