https://bugzilla.redhat.com/show_bug.cgi?id=2047560 Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |michel@xxxxxxxxxxxxxxx CC| |michel@xxxxxxxxxxxxxxx --- Comment #1 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> --- Taking this review. note: final approval pending per result of this discussion https://pagure.io/epel/issue/152 basically the issues are: - is this allowed for EPEL 9 given https://docs.fedoraproject.org/en-US/epel/epel-packaging/#limited_arch_packages says this is allowed for EPEL 7 but not EPEL 8 (and the new policy in https://pagure.io/epel/issue/134 of using a different, not the same, srpm name, could potentially address the issue blocking EPEL 8 anyway) - if so, should this be an `-epel` or an `-extras`? If the former, that means there are some `-epel` packages that are long lived, given LibRaw was excluded from aarch64 (let alone other more esoteric architectures) in RHEL 8 and is still excluded for RHEL 9. Apart from that, the spec very closely matches that of the original CentOS Stream 9 package, as seen below: ``` michel in fedora in LibRaw on c9s ❯ diff -u LibRaw.spec ~/src/fedora/reviews/2047560-LibRaw-epel/srpm-unpacked/LibRaw-epel.spec --- LibRaw.spec 2022-01-27 20:59:40.573832972 -0800 +++ /home/michel/src/fedora/reviews/2047560-LibRaw-epel/srpm-unpacked/LibRaw-epel.spec 2022-01-27 20:28:49.000000000 -0800 @@ -4,10 +4,14 @@ %global samples 1 %endif +%global origname LibRaw + +%global baserelease 6 + Summary: Library for reading RAW files obtained from digital photo cameras -Name: LibRaw +Name: %{origname}-epel Version: 0.20.2 -Release: 5%{?dist} +Release: 0%{?dist}.%{baserelease} License: BSD and LGPLv2 URL: http://www.libraw.org @@ -18,9 +22,12 @@ BuildRequires: autoconf automake libtool BuildRequires: make -Source0: http://github.com/LibRaw/LibRaw/archive/%{version}.tar.gz +Source0: http://github.com/LibRaw/LibRaw/archive/%{version}/%{origname}-%{version}.tar.gz Patch0: LibRaw-pkgconfig.patch -Provides: bundled(dcraw) = 9.25 + +# This is only for non-x86 architectures +# Cf. https://bugzilla.redhat.com/show_bug.cgi?id=2012272 +ExcludeArch: %{ix86} x86_64 %description LibRaw is a library for reading RAW files obtained from digital photo @@ -29,32 +36,43 @@ LibRaw is based on the source codes of the dcraw utility, where part of drawbacks have already been eliminated and part will be fixed in future. -%package devel +%package -n %{origname} +Summary: Library for reading RAW files obtained from digital photo cameras +Provides: bundled(dcraw) = 9.25 + +%description -n %{origname} +LibRaw is a library for reading RAW files obtained from digital photo +cameras (CRW/CR2, NEF, RAF, DNG, and others). + +LibRaw is based on the source codes of the dcraw utility, where part of +drawbacks have already been eliminated and part will be fixed in future. + +%package -n %{origname}-devel Summary: LibRaw development libraries -Requires: %{name}%{?_isa} = %{version}-%{release} +Requires: %{origname}%{?_isa} = %{version}-%{release} -%description devel +%description -n %{origname}-devel LibRaw development libraries. This package contains libraries that applications can use to build against LibRaw. -%package static +%package -n %{origname}-static Summary: LibRaw static development libraries -Requires: %{name}-devel%{?_isa} = %{version}-%{release} +Requires: %{origname}-devel%{?_isa} = %{version}-%{release} -%description static +%description -n %{origname}-static LibRaw static development libraries. -%package samples +%package -n %{origname}-samples Summary: LibRaw sample programs -Requires: %{name} = %{version}-%{release} +Requires: %{origname} = %{version}-%{release} -%description samples +%description -n %{origname}-samples LibRaw sample programs %prep -%autosetup -p1 -n %{name}-%{version} +%autosetup -p1 -n %{origname}-%{version} %build autoreconf -if @@ -85,19 +103,19 @@ rm -fv %{buildroot}%{_libdir}/lib*.la -%ldconfig_scriptlets +%ldconfig_scriptlets -n %{origname} -%files +%files -n %{origname} %doc Changelog.txt %license LICENSE.CDDL LICENSE.LGPL COPYRIGHT %{_libdir}/libraw.so.20* %{_libdir}/libraw_r.so.20* -%files static +%files -n %{origname}-static %{_libdir}/libraw.a %{_libdir}/libraw_r.a -%files devel +%files -n %{origname}-devel %doc manual %doc samples %{_includedir}/libraw/ @@ -108,12 +126,15 @@ %exclude %{_docdir}/libraw/* %if 0%{?samples} -%files samples +%files -n %{origname}-samples %{_bindir}/* %endif %changelog +* Fri Jan 28 2022 Neal Gompa <ngompa@xxxxxxxxxxxxxxxxx> - 0.20.2-0.6 +- Build for non-x86 arches in EPEL + * Mon Dec 13 2021 Debarshi Ray <rishi@xxxxxxxxxxxxxxxxx> - 0.20.2-5 - CDDL is not an approved license Resolves: #2031918 michel in fedora in LibRaw on c9s ❯ diff -u LibRaw-pkgconfig.patch ~/src/fedora/reviews/2047560-LibRaw-epel/srpm-unpacked/LibRaw-pkgconfig.patch michel in fedora in LibRaw on c9s ❯ ``` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2047560 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
