https://bugzilla.redhat.com/show_bug.cgi?id=2044393 --- Comment #6 from mmassari@xxxxxxxxxx --- Hi all, and thanks to your reviews. Since I have had many suggestions I summarized here below what you will find in my last specfile. 1. I used %autochangelog in the %changelog section 2. For the problem related with the ownership of twisted and twisted/plugins directories, I am using the following directive: %pycached %{python3_sitelib}/twisted/plugins/teamcity_plugin.py 3. I finally got to run the unit tests using tox, patching setup.py and tox.ini. But this leads to a new problem. I do not know why but the pypi source tarball does not have the tox.ini file in the tree. So patches did not apply. I tried to use the source tarball from github, which has the tox file in it, but the link is https://github.com/JetBrains/teamcity-messages/archive/refs/tags/v1.30.tar.gz and the downloaded file is teamcity-messages-1.30.tar.gz and for this reason rpmbuild complains with the uri... I managed to build the rpm using: Source0: teamcity-messages-1.30.tar.gz But now rpmlint gave me a new warning and also the reviewer tool . Because Source0 is not a valid URL. Do you have any better ideas on how I can manage this issue? 4. Since I am not using the macro %pyproject_check_import anymore. I got rid of pyproject_wheel and pyproject_install and I am using py3_build and py3_install instead. Link to COPR build: https://copr.fedorainfracloud.org/coprs/build/3255812 Link to KOJI build: https://koji.fedoraproject.org/koji/taskinfo?taskID=82002626 New SPEC URL: https://download.copr.fedorainfracloud.org/results/mmassari/teamcity-messages/fedora-rawhide-x86_64/03255812-python-teamcity-messages/python-teamcity-messages.spec New SRPM URL: https://download.copr.fedorainfracloud.org/results/mmassari/teamcity-messages/fedora-rawhide-x86_64/03255812-python-teamcity-messages/python-teamcity-messages-1.30-3.fc36.src.rpm rpmlint output =============================================================================== rpmlint session starts =============================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python-teamcity-messages.spec: W: invalid-url Source0: teamcity-messages-1.30.tar.gz ================================================ 0 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.2 s ================================================ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2044393 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
