https://bugzilla.redhat.com/show_bug.cgi?id=2045884 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #3 from Terje Røsten <terjeros@xxxxxxxxxxxx> --- spec could need some clean up: - remove support for el6 and python 2. - remove legacy stuff like: %if 0%{?fedora} >= 28 - I prefer to list one BR: per line, but it's ok as - if el6 goes, remove non systemd stuff etc ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package must own all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x ]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x ]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [-]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1648640 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. Rpmlint ------- uwsgi.x86_64: W: spelling-error %description -l en_US interprocess -> inter process, inter-process, intercession uwsgi.x86_64: W: spelling-error %description -l en_US preforking -> preforming, pitchforking uwsgi.x86_64: W: spelling-error %description -l en_US evented -> evened, vented, e vented uwsgi.x86_64: W: spelling-error %description -l en_US uGreen -> u Green, Green, green uwsgi.x86_64: W: spelling-error %description -l en_US xml -> XML, ml uwsgi.x86_64: W: spelling-error %description -l en_US ini -> uni, in, ii uwsgi.x86_64: W: spelling-error %description -l en_US yaml -> yam, yams, yawl uwsgi.x86_64: W: obsolete-not-provided uwsgi-loggers uwsgi.x86_64: W: obsolete-not-provided uwsgi-plugin-admin uwsgi.x86_64: W: obsolete-not-provided uwsgi-plugin-erlang uwsgi.x86_64: W: obsolete-not-provided uwsgi-router-access uwsgi.x86_64: W: obsolete-not-provided uwsgi-routers uwsgi.x86_64: W: crypto-policy-non-compliance-openssl /usr/sbin/uwsgi SSL_CTX_set_cipher_list uwsgi.x86_64: W: no-manual-page-for-binary uwsgi uwsgi-devel.x86_64: W: no-documentation A bit strange source is packaged as normal RPM under /usr/src, but it's ok. uwsgi-devel.x86_64: W: hidden-file-or-dir /usr/src/uwsgi/2.0.20/.github uwsgi-devel.x86_64: W: hidden-file-or-dir /usr/src/uwsgi/2.0.20/.github uwsgi-devel.x86_64: E: version-control-internal-file /usr/src/uwsgi/2.0.20/.gitignore uwsgi-devel.x86_64: E: zero-length /usr/src/uwsgi/2.0.20/INSTALL uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/contrib/centos_init_script 644 /bin/bash uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/contrib/securesubscribe.pl 644 /usr/bin/perl uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/contrib/subscribe.pl 644 /usr/bin/perl uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/contrib/upython 644 /bin/bash uwsgi-devel.x86_64: E: zero-length /usr/src/uwsgi/2.0.20/core/logging. uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/t/core/read_body_and_send.pl 644 /usr/bin/perl uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/t/core/url_sanitize.pl 644 /usr/bin/perl uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/t/perl/test_input_with_offset.pl 644 /usr/bin/perl uwsgi-devel.x86_64: E: non-executable-script /usr/src/uwsgi/2.0.20/t/python/manage_script_name/test_manage_script_name.py 644 /usr/bin/env python3 uwsgi-devel.x86_64: E: version-control-internal-file /usr/src/uwsgi/2.0.20/t/spooler/spooldir/.gitignore uwsgi-devel.x86_64: E: zero-length /usr/src/uwsgi/2.0.20/t/spooler/spooldir/.gitignore python3-uwsgidecorators.x86_64: W: spelling-error %description -l en_US uWSGI -> busgirl python3-uwsgidecorators.x86_64: W: no-documentation Would be nice to fix these: uwsgi-docs.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/uwsgi-docs/docs/PyPy.rst uwsgi-docs.x86_64: E: zero-length /usr/share/doc/uwsgi-docs/docs/examples/README.rst uwsgi-docs.x86_64: E: zero-length /usr/share/doc/uwsgi-docs/docs/tips_and_tricks/README.rst uwsgi-docs.x86_64: E: zero-length /usr/share/doc/uwsgi-docs/docs/tutorials/README.rst I guess these are plugins of some sort, ok. Unversioned so-files uwsgi-plugin-common: /usr/lib64/uwsgi/cgi_plugin.so uwsgi-plugin-common: /usr/lib64/uwsgi/http_plugin.so uwsgi-stats-pusher-file: /usr/lib64/uwsgi/stats_pusher_file_plugin.so uwsgi-stats-pusher-socket: /usr/lib64/uwsgi/stats_pusher_socket_plugin.so uwsgi-stats-pusher-statsd: /usr/lib64/uwsgi/stats_pusher_statsd_plugin.so uwsgi-stats-pusher-zabbix: /usr/lib64/uwsgi/zabbix_plugin.so uwsgi-alarm-curl: /usr/lib64/uwsgi/alarm_curl_plugin.so uwsgi-alarm-xmpp: /usr/lib64/uwsgi/alarm_xmpp_plugin.so uwsgi-transformation-chunked: /usr/lib64/uwsgi/transformation_chunked_plugin.so uwsgi-transformation-gzip: /usr/lib64/uwsgi/transformation_gzip_plugin.so uwsgi-transformation-offload: /usr/lib64/uwsgi/transformation_offload_plugin.so uwsgi-transformation-template: /usr/lib64/uwsgi/transformation_template_plugin.so uwsgi-transformation-tofile: /usr/lib64/uwsgi/transformation_tofile_plugin.so uwsgi-transformation-toupper: /usr/lib64/uwsgi/transformation_toupper_plugin.so uwsgi-log-encoder-msgpack: /usr/lib64/uwsgi/msgpack_plugin.so uwsgi-logger-crypto: /usr/lib64/uwsgi/logcrypto_plugin.so uwsgi-logger-file: /usr/lib64/uwsgi/logfile_plugin.so uwsgi-logger-graylog2: /usr/lib64/uwsgi/graylog2_plugin.so uwsgi-logger-pipe: /usr/lib64/uwsgi/logpipe_plugin.so uwsgi-logger-redis: /usr/lib64/uwsgi/redislog_plugin.so uwsgi-logger-rsyslog: /usr/lib64/uwsgi/rsyslog_plugin.so uwsgi-logger-socket: /usr/lib64/uwsgi/logsocket_plugin.so uwsgi-logger-syslog: /usr/lib64/uwsgi/syslog_plugin.so uwsgi-logger-systemd: /usr/lib64/uwsgi/systemd_logger_plugin.so uwsgi-logger-zeromq: /usr/lib64/uwsgi/logzmq_plugin.so uwsgi-plugin-airbrake: /usr/lib64/uwsgi/airbrake_plugin.so uwsgi-plugin-cache: /usr/lib64/uwsgi/cache_plugin.so uwsgi-plugin-carbon: /usr/lib64/uwsgi/carbon_plugin.so uwsgi-plugin-psgi: /usr/lib64/uwsgi/psgi_plugin.so uwsgi-plugin-coroae: /usr/lib64/uwsgi/coroae_plugin.so uwsgi-plugin-cheaper-busyness: /usr/lib64/uwsgi/cheaper_busyness_plugin.so uwsgi-plugin-cplusplus: /usr/lib64/uwsgi/cplusplus_plugin.so uwsgi-plugin-curl-cron: /usr/lib64/uwsgi/curl_cron_plugin.so uwsgi-plugin-dumbloop: /usr/lib64/uwsgi/dumbloop_plugin.so uwsgi-plugin-dummy: /usr/lib64/uwsgi/dummy_plugin.so uwsgi-plugin-fiber: /usr/lib64/uwsgi/fiber_plugin.so uwsgi-plugin-gccgo: /usr/lib64/uwsgi/gccgo_plugin.so uwsgi-plugin-geoip: /usr/lib64/uwsgi/geoip_plugin.so uwsgi-plugin-python3-gevent: /usr/lib64/uwsgi/python3_gevent_plugin.so uwsgi-plugin-glusterfs: /usr/lib64/uwsgi/glusterfs_plugin.so uwsgi-plugin-python3-greenlet: /usr/lib64/uwsgi/python3_greenlet_plugin.so uwsgi-plugin-ldap: /usr/lib64/uwsgi/ldap_plugin.so uwsgi-plugin-lua: /usr/lib64/uwsgi/lua_plugin.so uwsgi-plugin-mongrel2: /usr/lib64/uwsgi/mongrel2_plugin.so uwsgi-plugin-mono: /usr/lib64/uwsgi/mono_plugin.so uwsgi-plugin-nagios: /usr/lib64/uwsgi/nagios_plugin.so uwsgi-plugin-notfound: /usr/lib64/uwsgi/notfound_plugin.so uwsgi-plugin-pam: /usr/lib64/uwsgi/pam_plugin.so uwsgi-plugin-php: /usr/lib64/uwsgi/php_plugin.so uwsgi-plugin-pty: /usr/lib64/uwsgi/pty_plugin.so uwsgi-plugin-python3: /usr/lib64/uwsgi/python3_plugin.so uwsgi-plugin-rack: /usr/lib64/uwsgi/rack_plugin.so uwsgi-plugin-rbthreads: /usr/lib64/uwsgi/rbthreads_plugin.so uwsgi-plugin-rpc: /usr/lib64/uwsgi/rpc_plugin.so uwsgi-plugin-rrdtool: /usr/lib64/uwsgi/rrdtool_plugin.so uwsgi-plugin-ruby: /usr/lib64/uwsgi/ruby19_plugin.so uwsgi-plugin-spooler: /usr/lib64/uwsgi/spooler_plugin.so uwsgi-plugin-sqlite3: /usr/lib64/uwsgi/sqlite3_plugin.so uwsgi-plugin-ssi: /usr/lib64/uwsgi/ssi_plugin.so uwsgi-plugin-python3-tornado: /usr/lib64/uwsgi/python3_tornado_plugin.so uwsgi-plugin-ugreen: /usr/lib64/uwsgi/ugreen_plugin.so uwsgi-plugin-webdav: /usr/lib64/uwsgi/webdav_plugin.so uwsgi-plugin-xattr: /usr/lib64/uwsgi/xattr_plugin.so uwsgi-plugin-xslt: /usr/lib64/uwsgi/xslt_plugin.so uwsgi-plugin-zergpool: /usr/lib64/uwsgi/zergpool_plugin.so uwsgi-router-basicauth: /usr/lib64/uwsgi/router_basicauth_plugin.so uwsgi-router-cache: /usr/lib64/uwsgi/router_cache_plugin.so uwsgi-router-expires: /usr/lib64/uwsgi/router_expires_plugin.so uwsgi-router-fast: /usr/lib64/uwsgi/fastrouter_plugin.so uwsgi-router-forkpty: /usr/lib64/uwsgi/forkptyrouter_plugin.so uwsgi-router-hash: /usr/lib64/uwsgi/router_hash_plugin.so uwsgi-router-http: /usr/lib64/uwsgi/router_http_plugin.so uwsgi-router-memcached: /usr/lib64/uwsgi/router_memcached_plugin.so uwsgi-router-metrics: /usr/lib64/uwsgi/router_metrics_plugin.so uwsgi-router-radius: /usr/lib64/uwsgi/router_radius_plugin.so uwsgi-router-raw: /usr/lib64/uwsgi/rawrouter_plugin.so uwsgi-router-redirect: /usr/lib64/uwsgi/router_redirect_plugin.so uwsgi-router-redis: /usr/lib64/uwsgi/router_redis_plugin.so uwsgi-router-rewrite: /usr/lib64/uwsgi/router_rewrite_plugin.so uwsgi-router-spnego: /usr/lib64/uwsgi/router_spnego_plugin.so uwsgi-router-ssl: /usr/lib64/uwsgi/sslrouter_plugin.so uwsgi-router-static: /usr/lib64/uwsgi/router_static_plugin.so uwsgi-router-tuntap: /usr/lib64/uwsgi/tuntap_plugin.so uwsgi-router-uwsgi: /usr/lib64/uwsgi/router_uwsgi_plugin.so uwsgi-router-xmldir: /usr/lib64/uwsgi/router_xmldir_plugin.so All good here: Source checksums ---------------- Using local file uwsgi/uwsgi.tmpfiles as upstream file:///uwsgi/uwsgi.tmpfiles : CHECKSUM(SHA256) this package : 0b2d563704a1f1997ede3696523cbd34546797c3ada453df4649857695439cb7 CHECKSUM(SHA256) upstream package : 0b2d563704a1f1997ede3696523cbd34546797c3ada453df4649857695439cb7 Both ok fine: Requires -------- Provides -------- All in all: package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2045884 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
