https://bugzilla.redhat.com/show_bug.cgi?id=2044620 --- Comment #3 from Oleg Girko <ol+redhat@xxxxxxxxxxxxx> --- I've built a new version of the package with requested changes. Spec URL: https://infoserver.lv/~ol/files/algol68g.spec SRPM URL: https://infoserver.lv/~ol/files/algol68g-3.0.3-1.fc35.src.rpm (In reply to Zbigniew Jędrzejewski-Szmek from comment #1) > > Source: http://jmvdveer.home.xs4all.nl/%{name}-%{version}.tar.gz > https:// Done. > %description could/should be wrapped to 80 columns, not 64. Fitting in 64 columns is pure accidental. I was splitting lines to make each sentence start on a new line while still looking nice. > > %{_bindir}/* > Please list the files in /bin explicitly. This way a reader who doesn't know > the package > knows what the binary is, and this will also catch silly mistakes like > upstream adding a different > binary or a suffix an existing one. Done. > > %{_mandir}/man1/* > Same here, though less important. This usually would be something like > %{_mandir}/man1/algol.1* > to allow the default compression to be changed. Done. > > %license COPYING LICENSE > > %doc AUTHORS COPYING LICENSE NEWS README ChangeLog > It doesn't make sense to put COPYING and LICENSE in both. I'd drop them from > %doc. The problem is that these files are installed to docdir by "make install". I've excluded them explicitly. > > Release: 1%{?dist} > > %changelog > https://docs.pagure.org/fedora-infra.rpmautospec/index.html is recommended. May be, later. I use OBS to build and test my packages, and it doesn't support %autorelease yet (it generates Release value instead). And I can't use %autochangelog because my spec is not in Git repo yet. (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Note: No gcc, gcc-c++ or clang found in BuildRequires Added. > Note: Could not download Source0: > http://jmvdveer.home.xs4all.nl/algol68g-3.0.2.tar.gz New version has been just released, and author doesn't keep older versions on his site. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2044620 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
