https://bugzilla.redhat.com/show_bug.cgi?id=2044620 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > Source: http://jmvdveer.home.xs4all.nl/%{name}-%{version}.tar.gz https:// %description could/should be wrapped to 80 columns, not 64. > %{_bindir}/* Please list the files in /bin explicitly. This way a reader who doesn't know the package knows what the binary is, and this will also catch silly mistakes like upstream adding a different binary or a suffix an existing one. > %{_mandir}/man1/* Same here, though less important. This usually would be something like %{_mandir}/man1/algol.1* to allow the default compression to be changed. > %license COPYING LICENSE > %doc AUTHORS COPYING LICENSE NEWS README ChangeLog It doesn't make sense to put COPYING and LICENSE in both. I'd drop them from %doc. > Release: 1%{?dist} > %changelog https://docs.pagure.org/fedora-infra.rpmautospec/index.html is recommended. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2044620 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
