https://bugzilla.redhat.com/show_bug.cgi?id=2010116 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carl@xxxxxxxxxx Doc Type|--- |If docs needed, set a value Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx Flags| |fedora-review? --- Comment #3 from Carl George 🤠 <carl@xxxxxxxxxx> --- > I believe this section should reference the macros where applicable. (ie %{__mkdir_p}, %{__cp}, %{__install}). This is a stylistic choice. Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. mkdir, cp, and install are the right choice here. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > The spec should directly reference the names of these files. Agreed. The Python guidelines state this explicitly, but it's also a good general guideline. I'm probably going to work on getting a generic form into the main guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_explicit_lists Here are a few additional things I noticed that should be fixed. The metainfo file should be installed into %{_metainfodir}. -%{appdata_dir}/vim-surround.metainfo.xml +%{_metainfodir}/vim-surround.metainfo.xml https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ It's not directly mentioned in the guidelines, but similar to the patch status guideline, there should be a comment for Source1 linking to where the metainfo file was submitted upstream. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ The %post and %postun scriptlets are no longer necessary on Fedora or EPEL8+ due to file triggers in the main vim package. If and only if you plan to add this package to EPEL7, you can keep them with a conditional so they only apply on EPEL7. I suggest following the example of the docfiletriggers conditional in the vim-fugitive spec file. If you remove them, make sure to also remove the corresponding Requires(post) and Requires(postun). https://src.fedoraproject.org/rpms/vim/c/d76e3c95ac644b1ab577bf4db79fb055f218724d https://src.fedoraproject.org/rpms/vim-fugitive/blob/rawhide/f/vim-fugitive.spec Since the review was submitted, upstream has released version 2.2, so the spec file should be updated to that. https://github.com/tpope/vim-surround/releases/tag/v2.2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2010116 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
