https://bugzilla.redhat.com/show_bug.cgi?id=1936727 --- Comment #4 from Rich Mattes <richmattes@xxxxxxxxx> --- Thanks for the review, and sorry for the delay. I'm in the process of updating the gazebo-latest copr to provide a place to build a new version of this SRPM. I've updated to the latest 3.x release (staying with 3.x because gazebo-11 requires version 3), and correct the issues you've identified. I removed some of the non-apache licensed files in %prep, and included notes for the remaining files. The tiny_obj_loader.h file is a local fork of the tinyobjloader package, so I included a bundled virutal provides for it as well (our version of tinyobjloader is too old to build against). I've also added documentation for each patch. Spec URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/ignition-common/ignition-common-3.14.0-1.fc35.src.rpm Copr build (ignition dependency versions in rawhide are too old, version locked to gazebo-10): https://copr.fedorainfracloud.org/coprs/g/robotics-sig/gazebo-latest/build/3253668/ rpmlint: $ rpmlint ignition-common.spec ../SRPMS/ignition-common-3.14.0-1.fc35.src.rpm ../RPMS/x86_64/ignition-common{,-devel}-3.14.0-1.fc35.x86_64.rpm =================================================================================== rpmlint session starts =================================================================================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 ignition-common.x86_64: W: no-manual-page-for-binary ign_remotery_vis ignition-common-devel.x86_64: W: no-documentation ignition-common-devel.x86_64: W: files-duplicate /usr/lib64/cmake/ignition-common3/ignition-common3-config-version.cmake /usr/lib64/cmake/ignition-common3-all/ignition-common3-all-config-version.cmake:/usr/lib64/cmake/ignition-common3-events/ignition-common3-events-config-version.cmake:/usr/lib64/cmake/ignition-common3-graphics/ignition-common3-graphics-config-version.cmake:/usr/lib64/cmake/ignition-common3-profiler/ignition-common3-profiler-config-version.cmake ==================================================== 3 packages and 1 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 3.9 s ==================================================== The version files are all duplicates of each other because they are auto-generated by CMake and reflect the project's version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1936727 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
