https://bugzilla.redhat.com/show_bug.cgi?id=2041917 --- Comment #5 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- > %global rapidjson_version 1.1.0 > %global rapidjson_release 16 Doesn't seem to be any need of these globals, as there is only one use of them, so they can just be inlined. Also, it'd be very surprising if you really need a specific release. I think there's a bug in upstream's meson files as they don't appear to check for rapidjson? > Source1: %{name}.desktop > Source2: %{name}.metainfo.xml These are in v0.1 tarball now, aren't they? > BuildRequires: desktop-file-utils libappstream-glib rapidjson Already depending on rapidjson-devel, so no need for rapidjson too. > BuildRequires: meson SDL2-devel freetype-devel gtk3-devel libstdc++-static libstdc++-devel glibc-static pkg-config Doubtful that the *-static files are needed. libstdc++-devel will be required by g++, so not needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2041917 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
