https://bugzilla.redhat.com/show_bug.cgi?id=2034096 --- Comment #6 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- (In reply to mkulik from comment #4) > Few things: > > 1. Do you have any specific reason to use pypi sources ? According to > guidelines sources from for example github are preferred: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > #_source_files_from_pypi It doesn't say that; all it says is that you should use a tarball that isn't missing stuff. I don't want to use the GitHub tarball because they use versioneer and that is broken without a git checkout. > 2. During test stage we can see bunch of errors like: > > > PytestUnknownMarkWarning: Unknown pytest.mark.request - is this a typo? You can register custom marks to avoid this warning - for details... > > This probably should be addressed. It seems that this marker is defined in > github sources but missing in pypi: > https://github.com/geopandas/xyzservices/blob/main/pytest.ini. > Fixed. (In reply to mkulik from comment #5) > In %doc I can see that you put README file from root of the project. This is > more general purpose file that includes information such as: installation > process, and it should not be included as documentation: > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation I wouldn't call it entirely general purpose; install information is only a single section there. > There is also proper doc directory from which documentation should be > generated. It's rather small so separate package for it won't be necessary. The API docs are not in the PyPI sdist, and would require several new packages just to build, so I'd rather not include them. Updated: Spec URL: https://qulogic.fedorapeople.org/python-xyzservices.spec SRPM URL: https://qulogic.fedorapeople.org/python-xyzservices-2022.1.1-1.fc34.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2034096 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
