[Bug 2036291] Review Request: python-sphinx-panels - Sphinx extension for creating panels in a grid layout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2036291



--- Comment #4 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> ---
(In reply to Jerry James from comment #3)
> Issues:
> =======
> - Package does not contain duplicates in %files.
>   Note: warning: File listed twice: /usr/share/licenses/python3-sphinx-
>   panels/LICENSE
>   See: https://docs.fedoraproject.org/en-US/packaging-
>   guidelines/#_duplicate_files
> 
>   The issue is that both files listed in %license are named LICENSE.  Note
> that
>   both files also appear elsewhere:
>   /usr/lib/python3.10/site-packages/sphinx_panels-0.6.0.dist-info/LICENSE
>   /usr/lib/python3.10/site-packages/sphinx_panels/data/LICENSE
>

I removed the dist-info/ one, because %pyproject_save_files automatically tags
it as %license.

I've had to leave the data/ one in, though, which still gets a warning due to
it being in the macro.

> - Ah, good old American English.  The %description uses British English
>   spellings (optimised, utilising) instead of American English spellings
>   (optimized, utilizing).
> 

Fixed.

> - Since upstream did not provide any tests, please consider adding a %check
>   script that invokes %pyproject_check_import.  See
>  
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/
> #pyproject_check_import

Added.

Spec URL: https://qulogic.fedorapeople.org/python-sphinx-panels.spec
SRPM URL:
https://qulogic.fedorapeople.org/python-sphinx-panels-0.6.0-2.fc34.src.rpm


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2036291
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux