https://bugzilla.redhat.com/show_bug.cgi?id=2036468 --- Comment #34 from Christoph Erhardt <fedora@xxxxxxxxxxx> --- I have uploaded a new revision that fixes most of the remarks. There's one failure I seem unable to fix because the build fails on rawhide if I replace `%define` with `%global`: [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define build_args PREFIX=%{_prefix} LIBDIR=%{_libdir} CC=gcc CXX=g++ CFLAGS="%{build_cflags}" CXXFLAGS="%{build_cxxflags}" LDFLAGS="%{build_ldflags}" STRIP=echo SYSTEM_MIMALLOC=1 SYSTEM_XXHASH=1 The build error in question looks as follows - note the incomplete path; it should be `/builddir/build/BUILD/mold-1.0.2/.package_note-mold-1.0.2-1.fc36.x86_64.ld`: /usr/bin/ld: cannot open linker script file /builddir/build/BUILD/.package_note-mold-1.0.2-1.fc36.x86_64.ld: No such file or directory Concerning rpmlint, I'm unsure how to get these two messages fixed: mold.x86_64: E: non-readable /usr/bin/ld 0 mold.x86_64: W: non-executable-in-bin /usr/bin/ld 0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2036468 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
