https://bugzilla.redhat.com/show_bug.cgi?id=2022991 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > BuildRequires: systemd-units There is not such package since a long long time, this virtual provides is now attached to systemd. And in general you don't need to pull in systemd for the build. (It has a lot of dependencies, so it's nicer to avoid it.) If you only need %{_unitdir} and such, systemd-rpm-macros is enough. > C++ implementation of I2P. It'd be nice to expand this a bit. The implementation language usually isn't important to users, and many people will not know who I2P is… > Obsoletes: %{name}-daemon > Obsoletes: %{name}-systemd Those should be versioned, with a fixed version, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages. > Requires: systemd This should be removed. The general idea is that on a normal system you'll have systemd installed anyway, so the dependency doesn't matter. But if someone is building e.g. a container image w/o systemd or something custom, the dependency just gets in the way. > Requires: logrotate Hmm, this is allowed, and there certainly are packages using custom logs, but since you're introducing the package to Fedora, it is an easy moment to change user expectations. If the program doesn't log too much, it'd be nicer to just let it log to the journal because the UX is better. Did you consider using %autorelease and %autochangelog? This would make the packaging even a bit easier [https://docs.pagure.org/fedora-infra.rpmautospec/]. In general this spec file look OK to me. We should wait for https://pagure.io/packaging-committee/issue/1158 to be resolved, but at least my understanding (as a person who worked on the new macros…), that the classical version is still OK. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2022991 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
