Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: qemu-launcher - A graphical front-end to Qemu virtual machines https://bugzilla.redhat.com/show_bug.cgi?id=400521 ------- Additional Comments From nsboyle@xxxxxxxxx 2007-12-01 13:25 EST ------- (In reply to comment #1) > rpmlint gave > qemu-launcher.i386: E: no-binary > The package should be of the noarch architecture because it doesn't contain > any binaries. Done. Updated file: Spec URL: http://nboyle.fedorapeople.org/qemu-launcher.spec SRPM URL: http://nboyle.fedorapeople.org/qemu-launcher-1.7.4-1.fc8.src.rpm I also caught some other changes to make: Changed group to Applications/Emulators I'm no longer patching the Makefile. Until I saw an example in another spec file, it wasn't obvious to me that it was possible to change Makefile variables in the make install command (ex: make install PREFIX="/usr"), but I get that now. :) I've left the patch for the desktop file, as I'm not sure of any other elegant way to handle alterations to that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review