[Bug 2006765] Review Request: libi2cd - C library for interacting with linux I2C devices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2006765

Peter Robinson <pbrobinson@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |RAWHIDE
             Status|POST                        |CLOSED
        Last Closed|                            |2022-01-23 12:06:33



--- Comment #7 from Peter Robinson <pbrobinson@xxxxxxxxx> ---
(In reply to Petr Menšík from comment #5)
> I don't like your attitude. You refuse even simple improvements to spec
> file, because it is not mandatory. Well, it is not mandatory for me as a
> reviewer to give you review+. I have seriously considered just unassigning
> myself and leaving such review to someone else.

Me having a different opinion to yours doesn't mean I have a bad attitude.
There's a difference. With the update you put there I would have preferred you
did walk away but here we are.

A minor bugfix release won't substantially change the package and hence it
won't impact the review. The review has sat there for 4 months to update it for
each minor bump takes time and that IMO is a waste. Now if there was a major
bump with API change I would have completely updated it, probably long before
you came along.

In the case of the check, from my experience (I have been packaging rpms since
1996) if it's not run all the time it just rots as in reality no one runs it
locally. In the case of running it on say a VM which doesn't have i2c (and I do
a lot of building on VMs) it would fail.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2006765
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux