Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: patch https://bugzilla.redhat.com/show_bug.cgi?id=226233 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-12-01 05:53 EST ------- rpmlint output => patch.src: I: checking patch.src: E: non-utf8-spec-file /tmp/patch-2.5.4-30.fc8.src.rpm.6404/patch.spec The character encoding of the spec file is not UTF-8. Convert it for example using iconv(1). patch.src: W: patch-not-applied Patch8: patch-selinux.patch A patch is included in your package but was not applied. Refer to the patches documentation to see what's wrong. patch.src: E: tag-not-utf8 %changelog The character encoding of the value of this tag is not UTF-8. Also, 1)use macros under %files section check =>http://fedoraproject.org/wiki/Packaging/RPMMacros 2) use of parallel make check => http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e 3) avoid makeinstall usage =>http://fedoraproject.org/wiki/Packaging/Guidelines#head-fcaf3e6fcbd51194a5d0dbcfbdd2fcb7791dd002 4)Good to have defattr used as %defattr(-,root,root,-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review