[Bug 2041235] Review Request: calindori - Calendar application for Plasma Mobile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2041235



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Initial spec review:

> %description
> %{summary}

This should be "%{summary}." in the description simply to make rpmlint shut up.

> %prep
> %autosetup -n %{name}-%{version}

"-n %{name}-%{version}" is superfluous, since that's the default. Drop it.

> %find_lang %{name}
> %find_lang calindac

Add "cat %{name}.lang calindac > %{name}-full.lang" so that later you can...

> %files -f %{name}.lang

Use "%{name}-full.lang" here, and...

> %{_kf5_datadir}/locale/*/LC*/calindac*

Drop this.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2041235
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux