https://bugzilla.redhat.com/show_bug.cgi?id=2020307 Arthur Bols <arthur@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #8 from Arthur Bols <arthur@xxxxxxxx> --- Again a licensing issue. :/ I'm in a hurry so here's a quick rundown of issues, but overall it looks quite good. - Add a license breakdown - Report the missing licenses upstream - Add the README.md with %doc > sed -i 's/SocialMedia/X-SocialMedia/g' %{buildroot}%{_kf5_datadir}/applications/org.kde.%{name}.desktop You have a commit upstream to fix it. Please add it as a comment so you won't forget to remove it in the future. A patch would be better. I'm fine with it in this case, since it should be gone in the next release. > %license LICENSES/*.txt You can remove the .txt to match all files. This would be useful if they add a license file without extension. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2020307 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
