https://bugzilla.redhat.com/show_bug.cgi?id=2043581 Lokesh Mandvekar <lsm5@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(lsm5@xxxxxxxxxx) | --- Comment #2 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> --- Spec URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/aardvark-dns.spec SRPM URL: https://gitlab.com/lsm5/aardvark-dns/-/raw/main/SRPMS/aardvark-dns-0-0.1.gitbab0ac1.fc35.src.rpm (In reply to Jindrich Novy from comment #1) > The package contains undefined macros: > > Release: %autorelease > %autochangelog See: https://docs.pagure.org/fedora-infra.rpmautospec/principle.html I removed %autorelease since we don't have a versioned release upstream yet. But let's keep %autochangelog. > > Version: 0 ? No upstream tag yet. > > loads of useless commented out stuff: > #%%cargo_prep > > #%%generate_buildrequires > #%%cargo_generate_buildrequires Removed. I'd kept it as a reminder to anyone looking that rust2rpm doesn't work because dependencies missing, but anyway. > > I'd be more verbose than this: > %global _description %{expand: > %{summary}} done. > > This one misses build requires? > ExclusiveArch: %{rust_arches} done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2043581 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
