https://bugzilla.redhat.com/show_bug.cgi?id=2041917 Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |quantum.analyst@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #3 from Elliott Sales de Andrade <quantum.analyst@xxxxxxxxx> --- > Source1: https://github.com/Tencent/rapidjson/archive/1c2c8e085a8b2561dff17bedb689d2eb0609b689.tar.gz rapidjson is already packaged; why use a bundled copy? > Source2: https://github.com/dorindabassey/gpuvis/blob/master/rpm/%{name}.desktop > Source3: https://github.com/dorindabassey/gpuvis/blob/master/rpm/%{name}.metainfo.xml You should send these files upstream. > #-march=native option in makefile not supported on powerpc use -mtune=native > %ifarch ppc64le > sed -i 's/-march=native/-mtune=native/g' Makefile > %endif Packages cannot use -march=native; they must use standard compiler flags. You could fix the Makefile, but ... > %build > mkdir -p lib/rapidjson > tar --strip-components=1 -xvf %{SOURCE1} -C lib/rapidjson > make %{?_smp_mflags} USE_GTK3=0 ASAN=0 CFG=debug > %make_build ... why not use Meson and the Meson build macros? https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/ > %install > #makefile has no install target so write install in the spec file The Meson build will know how to install. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2041917 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
