https://bugzilla.redhat.com/show_bug.cgi?id=2029547 mkulik@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkulik@xxxxxxxxxx --- Comment #5 from mkulik@xxxxxxxxxx --- Hi, 1. I would drop this section from description: > Features: > ... > Supported Derivation algorithms: > * Argon2 KDBX4 > * AES-KDF KDBX 3.1 This section should be a short and concise description of the package without special unicodes. 2. We can probably also add %meson_test to %check instead ? It seems to check the same things: > 1/3 Validate desktop file OK 0.02s > 2/3 Validate metainfo file OK 0.05s > 3/3 Validate schema file OK 0.02s 3. Looking at: https://gitlab.gnome.org/World/secrets/-/blob/master/meson_options.txt We can tests with default option defined as false. We can include them by adding option to this macro: %meson -Dtests=true. Probably worth to use bcond for it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2029547 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
