[Bug 2034096] Review Request: python-xyzservices - Source of XYZ tiles providers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2034096



--- Comment #4 from mkulik@xxxxxxxxxx ---
Few things:

1. Do you have any specific reason to use pypi sources ? According to
guidelines sources from for example github are preferred:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi
2. During test stage we can see bunch of errors like:

> PytestUnknownMarkWarning: Unknown pytest.mark.request - is this a typo?  You can register custom marks to avoid this warning - for details...

This probably should be addressed. It seems that this marker is defined in
github sources but missing in pypi:
https://github.com/geopandas/xyzservices/blob/main/pytest.ini.

I'm still reviewing it. I will post more issues if I find any.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2034096
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux