https://bugzilla.redhat.com/show_bug.cgi?id=2017119 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxx --- Comment #15 from Paul Howarth <paul@xxxxxxxxxxxx> --- Hi Graham, I have sponsored you. I lurk on the httpd dev list and am comfortable with your abilities. Please feel free to contact me directly if you have any questions about Fedora processes and I'll do my best to help out. Just a few minor things on this package: 1. In the %prep section, after running "%setup -q" the current directory is automatically set to %{_builddir}/%{name}-%{version} so you could simplify "rm -rf %{_builddir}/%{name}-%{version}/debian" to just "rm -rf debian". In fact if the files in there do not affect the result of the build, you don't even need to do that - the only files that will will end up in the final package are those in the %files list. 2. It's normal to use gcc rather than clang unless upstream does not support gcc or there's some other good reason not to use gcc (see https://docs.fedoraproject.org/en-US/packaging-guidelines/#compiler). 3. I'd have a blank line before %build in the spec file to clearly separate the %prep, %build, %install, %check (not present here but may be in other packages) and %files sections, which I think helps readability. Jakub, you should probably assign this ticket back to yourself since you did the actual review. Cheers, Paul. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2017119 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
