Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdebase3 - K Desktop Environment - core files https://bugzilla.redhat.com/show_bug.cgi?id=405221 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide ------- Additional Comments From kevin@xxxxxxxxxxxxxxxx 2007-11-30 21:42 EST ------- I took the liberty to fix the rpmlint warnings which are actual problems: > > kdebase3.src:2394: W: macro-in-%changelog post > Bad, % should be escaped. Fixed. > > kdebase3.i386: E: percent-in-obsoletes kdebase-extras 6: %{version}-%{release} > > kdebase3.i386: E: percent-in-provides kdebase-extras 6: %{version}-%{release} > Macros not expanded properly, this one needs fixing! Fixed. > > kdebase3-devel.i386: W: obsolete-not-provided kdebase-devel > > kdebase3-devel.i386: E: useless-explicit-provides kdebase3-devel > But this one is a mistake (kdebase3-devel providing itself rather than > kdebase-devel to match the Obsoletes or nothing). Fixed. Spec URL: http://repo.calcforge.org/f9/kdebase3.spec SRPM URL: http://repo.calcforge.org/f9/kdebase3-3.5.8-12.fc7.src.rpm (I removed the binary RPMs because they're outdated and rpmlint has been done already anyway, if you want to test, please rebuild the current SRPM.) * Sat Dec 01 2007 Kevin Kofler <Kevin@xxxxxxxxxxxxxxxx> - 6:3.5.8-12 - merge updated ConsoleKit patch with Mandriva's (Nicolas Lécureuil's) xdmcp fixes from kdebase-3.5.8-9 (#243560, Mandriva#34786) - build as kdebase3 on F9+ (not F10+) - fix unescaped macros and a typo in changelog - move kdebase-extras Provides/Obsoletes to the correct place - fix check of %%{name} against "kdelibs" instead of "kdebase" - fix Provides/Obsoletes for kdebase3-libs and kdebase3-devel This resolves the rpmlint part and is now ready for the manual review checklist. IMPORTANT: The temporary hack forcing %fedora to 9 for testing purposes will have to go away before/after import, at the very least before this is ever committed to a non-F9 branch. ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review