https://bugzilla.redhat.com/show_bug.cgi?id=2040118 --- Comment #5 from Garry T. Williams <gtwilliams@xxxxxxxxx> --- Spec URL: https://raw.githubusercontent.com/gtwilliams/deal/master/deal.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7215/81247215/deal-3.1.9-1.fc35.src.rpm (In reply to Artur Frenszek-Iwicki from comment #4) > > > You can try the following instead: > > > 1. Call "%set_build_flags" at the start of %build to set Fedora's > > > CFLAGS/CXXFLAGS > > > 2. Use "+=" in the Makefile to append -fPIE instead of overwriting > > I chose the second; also added required -g in the same change. > > Sorry, my wording was confusing here. Those aren't exclusive options, but > rather two steps to a single solution. Yeah, now that I read again what you wrote, I see. This was useful. Adding Fedora's flags uncovered two (benign) -Wunused-but-set-variable warnings that I just fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2040118 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
