https://bugzilla.redhat.com/show_bug.cgi?id=2037645 --- Comment #23 from José Matos <jamatos@xxxxxxxx> --- Running fedora-review identifies the following issues: - Header files in -devel subpackage, if present. Note: cantera-common : /usr/share/cantera/samples/cxx/bvp/BoundaryValueProblem.h cantera-common : /usr/share/cantera/samples/cxx/kinetics1/example_utils.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cantera/doc/LICENSE.txt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: cantera-devel. Does not provide -static: cantera-devel. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries The first 2 are false-positives, in the sense that the first header file corresponds to an example. The second case is justified since that is the license file that is present in the documentation. The third case is true and it should be solved. Other than that I have no further remarks... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2037645 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
