https://bugzilla.redhat.com/show_bug.cgi?id=2034532 --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- This package looks really good! I have just a few small comments: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Looks like BuildRequires: gcc would be the appropriate thing to add here. The vala package does not appear to depend directly on gcc, but it transpiles Vala to C and requires a C compiler. (I missed this on my own vala packages and just had to go fix it.) - Dist tag is present. (OK: fedora-review is confused by rpmautospec) - Please add %doc AUTHORS %doc CONTRIBUTORS - It’s possible to provide translated versions of the description and summary in the spec file, since upstream contains translations for appropriate AppData file strings, e.g. from po/de.po: #: data/pantheon-tweaks.appdata.xml.in:6 src/Tweaks.vala:40 msgid "Tweak Pantheon settings" msgstr "Pantheons Einstellungen optimieren" #: data/pantheon-tweaks.appdata.xml.in:8 msgid "" "A system settings panel for the Pantheon Desktop that lets you easily and " "safely customise your desktop's appearance." msgstr "" "Ein Systemeinstellungsmodul für die Arbeitsumgebung »Pantheon«, mit die " "Erscheinung der Arbeitsumgebung sicher und einfach angepasst werden kann." (In some cases, only the summary is translated.) This is casually mentioned in the guidelines at https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description. Please see https://src.fedoraproject.org/rpms/appeditor/blob/8afdf490c0a7dbe84cb7887442c46bfdf2e311ef/f/appeditor.spec for a practical example. Despite fedora-review having a checklist item for this, it is not mandatory, and the guidelines don’t even say you “SHOULD” do it, so you may ignore this item if you choose. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. /usr/lib64/switchboard/personal/libpantheon-tweaks.so is a properly-installed plugin. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later". 57 files have unknown license. Detailed output of licensecheck in /home/reviewer/2034532-switchboard-plug-tweaks/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [-]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. Appropriate string translations are present, so you could do this if you want to. It isn’t mandatory and isn’t even officially a SHOULD in the guidelines. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. Upstream provides no tests, so there is nothing to do other than the AppData validation. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- switchboard-plug-tweaks: /usr/lib64/switchboard/personal/libpantheon-tweaks.so Source checksums ---------------- https://github.com/pantheon-tweaks/pantheon-tweaks/archive/1.0.3/pantheon-tweaks-1.0.3.tar.gz : CHECKSUM(SHA256) this package : 11be8e8f8114561e8057c443e2a4b3cc60dceec9570b2d5e4b9332640d1e23e0 CHECKSUM(SHA256) upstream package : 11be8e8f8114561e8057c443e2a4b3cc60dceec9570b2d5e4b9332640d1e23e0 Requires -------- switchboard-plug-tweaks (rpmlib, GLIBC filtered): hicolor-icon-theme libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgee-0.8.so.2()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite.so.6()(64bit) libgtk-3.so.0()(64bit) libswitchboard-2.0.so.0()(64bit) rtld(GNU_HASH) switchboard(x86-64) switchboard-plug-tweaks-debuginfo (rpmlib, GLIBC filtered): switchboard-plug-tweaks-debugsource (rpmlib, GLIBC filtered): Provides -------- switchboard-plug-tweaks: metainfo() metainfo(pantheon-tweaks.appdata.xml) switchboard-plug-tweaks switchboard-plug-tweaks(x86-64) switchboard-plug-tweaks-debuginfo: debuginfo(build-id) libpantheon-tweaks.so-1.0.3-1.fc36.x86_64.debug()(64bit) switchboard-plug-tweaks-debuginfo switchboard-plug-tweaks-debuginfo(x86-64) switchboard-plug-tweaks-debugsource: switchboard-plug-tweaks-debugsource switchboard-plug-tweaks-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2034532 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: SugarActivity, Perl, Ocaml, Haskell, PHP, fonts, Java, R, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 switchboard-plug-tweaks-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/switchboard/personal/libpantheon-tweaks.so-1.0.3-1.fc36.x86_64.debug switchboard-plug-tweaks-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/switchboard/personal/libpantheon-tweaks.so-1.0.3-1.fc36.x86_64.debug switchboard-plug-tweaks-debuginfo.x86_64: W: no-documentation switchboard-plug-tweaks-debugsource.x86_64: W: no-documentation switchboard-plug-tweaks-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/96/566a1ff7b87e432f3262a4fe23f27ca7dbd9bf ../../../.build-id/96/566a1ff7b87e432f3262a4fe23f27ca7dbd9bf 4 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken 0.6 s -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2034532 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
