[Bug 2039531] Review Request: python-pyqt-feedback-flow - Show feedbacks in toast-like notifications

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2039531

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
Approved by inspection of the spec file diff.

Note that the BuildRequires on pytest is not actually needed if you are only
running %pyproject_check_import.

--- ../srpm-unpacked/python-pyqt-feedback-flow.spec     2022-01-11
16:03:36.000000000 -0500
+++
2039531-python-pyqt-feedback-flow/srpm-unpacked/python-pyqt-feedback-flow.spec 
    2022-01-12 10:43:52.000000000 -0500
@@ -23,6 +23,7 @@
 BuildRequires:  python3-devel

 BuildRequires:  %{py3_dist toml-adapt}
+BuildRequires:  %{py3_dist pytest}

 %description %_description

@@ -50,6 +51,10 @@

 %pyproject_save_files pyqt_feedback_flow

+%check
+# use smoke test
+%pyproject_check_import
+
 %files -n python3-%{pypi_name} -f %{pyproject_files}
 %license LICENSE
 %doc README.md


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2039531
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux