https://bugzilla.redhat.com/show_bug.cgi?id=2039649 --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Nit-picks and suggestions: Summary: File metadata and streaming library for 3D-printing related file formats. -> remove the dot, summaries are not sentences Source0: %{url}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz -> Source0: %{url}/archive/%{version}/%{name}-%{version}.tar.gz (less of a hack) BuildArch: noarch -> BuildArch: noarch (add more spaces to align with the rest of the tags) %autosetup -n libCharon-%{version} -p1 -S git (this requires BuildRequiring git-core) %{__python3} -m pip freeze -> %{python3} -m pip freeze (also seems like you need to BuildRequire python3-pip to make it work?) %{__python3} -m pytest -v -> %pytest -v (a new macro) Does the package even build with the missing BRs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2039649 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
