https://bugzilla.redhat.com/show_bug.cgi?id=2006685 --- Comment #4 from Artur Frenszek-Iwicki <fedora@xxxxxxxxxx> --- > - Shouldn't the license be "GPLv2+"? I see the "any later version" phrase in > the individual Pascal files. Good catch. Fixed. > - The LICENSE file contains an address for the FSF that has been out of date > for 16 years. Please ask upstream to refresh the text of that file Done. https://github.com/pasdoc/pasdoc/issues/136 > - I don't see any Pascal-specific packaging guidelines, so I'm not sure what > the build flags should be. I have a question about the use of "-gw", though. > That generates DWARF-2 debuginfo. Fedora's toolchain works with at least > DWARF-4, and I think I saw some messages not too long ago about migrating to > DWARF-5. Shouldn't this package use either "-gw3" or "-gw4" to build? I went with DWARF-3 for two reasons: 1. In the FPC manual, -gw4 is described as "experimental". https://www.freepascal.org/docs-html/current/user/usersu15.html 2. Lazarus doesn't even support setting Dwarf4 in project settings. https://gitlab.com/freepascal.org/lazarus/lazarus/-/blob/lazarus_2_2_0/components/buildintf/compoptsintf.pas#L89 > - Since this package installs a graphical application with a desktop file, > please consider adding an AppData file as well: Eh. Might as well. Added. > - As rpmlint points out, the icon installed in the 512x512 directory is actually > 480x480. The fake-512px icon is no longer installed. spec: https://svgames.pl/fedora/pasdoc-0.16.0-4/pasdoc.spec srpm: https://svgames.pl/fedora/pasdoc-0.16.0-4/pasdoc-0.16.0-4.fc34.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=81073710 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2006685 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
