https://bugzilla.redhat.com/show_bug.cgi?id=2023307 --- Comment #6 from Jakub Ruzicka <jakub.ruzicka@xxxxxx> --- Hello Petře and thank you for your review. > Is there reason, why is not %cmake macro used instead of manual cmake? I've started with that following fedora docs, but it wasn't working on EL/EPEL 7. Instead of maintaining 2 different .spec files, I decided to use a method that works on all currently supported systems. I'd be happy for a better solution here. > Why is make used instead of %make_build, make install instead of %make_install? I don't remember if there was an issue with these as well... maybe just general distrust in macros that behave differently across different distro releases. I'll try changing per your suggestion and see if that works. I'll address other issues you pointed out not related to cmake, but assuming I can't use the %cmake macro due to EL 7 support: > - LDFLAGS not used at all. use %cmake macro to pass all needed flags, omit cmake command directly Any example on howto do it manually? > - use %cmake_build and %cmake_install instead of manual make calls If my manual invocation is incorrect, could you please point me in the right direction without the %cmake macros? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2023307 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
