https://bugzilla.redhat.com/show_bug.cgi?id=2012612 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Petr Pisar <ppisar@xxxxxxxxxx> --- The standalone spec file and the spec file from the source RPM package differ. There is some rpmautospec cruft. I will use the standalone one because it does not contain a changelog broken by rpmautospec: $ rpmbuild -ba perl-Authen-ModAuthPubTkt.spec error: bad date in %changelog: sam. janv. 08 2022 Robert-André Mauchin <zebob.m@xxxxxxxxx> 0.1.1-2 error: Failed build dependencies: perl(IPC::Run3) is needed by perl-Authen-ModAuthPubTkt-0.1.1-2.fc36.noarch URL and Source0 addresses are usable. Ok. TODO: Please change Source0 address to <https://cpan.metacpan.org/authors/id/A/AG/AGORDON/Authen-ModAuthPubTkt-0.1.1.tar.gz> as listed on the home page. Or at least change the protocol from HTTP to HTTPS. Source archive (SHA-512: 4e99ee35f8c33f03182831478b2d00e184fd5f21e6c3f6413298479c9e127e584ec38abd9af328c764bb87c101b1490b38d7c60f684624df0159f4644b2875b0) is original. Ok. Author changed a license to "GPL+ or Artistic" as documented in the patch and in the upstream's ticket. Ok. Summary verified from lib/Authen/ModAuthPubTkt.pm. Ok. Description verified from lib/Authen/ModAuthPubTkt.pm. Ok. License verified from README, Makefile.PL, lib/Authen/ModAuthPubTkt.pm, and eg/mod_auth_pubtkt.pl. Ok. No XS code, noarch BuildArch is Ok. A dependency on openssl is Ok. FIX: Build-require 'perl(Exporter)' (lib/Authen/ModAuthPubTkt.pm:2). FIX: Build-require 'coreutils' (perl-Authen-ModAuthPubTkt.spec:48). Test::CheckManifest not used. Ok. All tests pass. Ok. $ rpmlint perl-Authen-ModAuthPubTkt.spec ../SRPMS/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.src.rpm ../RPMS/noarch/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.noarch.rpm ================================= rpmlint session starts ================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 perl-Authen-ModAuthPubTkt.noarch: W: no-manual-page-for-binary mod_auth_pubtkt.pl == 2 packages and 1 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.5 s == rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.noarch.rpm -rwxr-xr-x 1 root root 4899 Jan 10 14:48 /usr/bin/mod_auth_pubtkt.pl drwxr-xr-x 2 root root 0 Jan 10 14:48 /usr/share/doc/perl-Authen-ModAuthPubTkt -rw-r--r-- 1 root root 90 Jun 21 2012 /usr/share/doc/perl-Authen-ModAuthPubTkt/Changes -rw-r--r-- 1 root root 1019 Jun 21 2012 /usr/share/doc/perl-Authen-ModAuthPubTkt/META.json -rw-r--r-- 1 root root 6902 Jan 10 14:48 /usr/share/doc/perl-Authen-ModAuthPubTkt/README -rw-r--r-- 1 root root 130 Jun 21 2012 /usr/share/doc/perl-Authen-ModAuthPubTkt/ignore.txt -rw-r--r-- 1 root root 3896 Jan 10 14:48 /usr/share/man/man3/Authen::ModAuthPubTkt.3pm.gz drwxr-xr-x 2 root root 0 Jan 10 14:48 /usr/share/perl5/vendor_perl/Authen -rw-r--r-- 1 root root 10601 Jan 10 14:48 /usr/share/perl5/vendor_perl/Authen/ModAuthPubTkt.pm TODO: Do not package META.JSON and ignore.txt files. Those are not helpful for a user. $ rpm -q --requires -p ../RPMS/noarch/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 openssl 1 perl(:MODULE_COMPAT_5.34.0) 1 perl(Authen::ModAuthPubTkt) 1 perl(Carp) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(IPC::Run3) 1 perl(MIME::Base64) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.noarch.rpm | sort -f | uniq -c 1 perl(Authen::ModAuthPubTkt) = 0.1.1 1 perl-Authen-ModAuthPubTkt = 0.1.1-1.fc36 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Authen-ModAuthPubTkt-0.1.1-1.fc36.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in Fedora 36 <https://koji.fedoraproject.org/koji/taskinfo?taskID=81062780>. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct the FIX items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2012612 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
