https://bugzilla.redhat.com/show_bug.cgi?id=2038591 --- Comment #3 from Maxwell G <gotmax@e.email> --- Are you licensing this under GPLv3+, because that's the license of the ansible package? I think it can also be argued that this is MIT, because that's Fedora's implicit license. You might want to check with Igor Raits, the original author of the macros/generators[1], about the licensing. Honestly, I think it's problematic that Fedora relies on implicit licenses while still recommending that upstream ships explicit license files, but I don't know the full context surrounding this decision. The other problem is that this package does not depend on any package that provides /usr/bin/ansible-galaxy. Currently, every supported Fedora version has both `ansible` 2.9 and `ansible-core` (they conflict with each other), but Epel 7 and 8 only have the former. As you know, EL 9 itself already contains `ansible-core`. I think this package should depend on ansible-core wherever possible. Then, we can have collections BR `ansible-packaging` and get rid of the current `BuildRequires: (ansible >= 2.9.10 or ansible-core >= 2.11.0)` which defaults to ansible. I would suggest something like this: ``` %if 0%{?fedora} >= 34 || 0%{?rhel} >= 9 Requires: ansible-core >= 2.11.0 %else Requires: ansible >= 2.9.10 ``` We will also need to address the generated requires. [1]: https://src.fedoraproject.org/rpms/ansible/c/db3f8ce6dcb8907cf9e5e06ee399a18c6696887a?branch=rawhide -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2038591 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
