https://bugzilla.redhat.com/show_bug.cgi?id=2036758 --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- I see you converted to pyproject-rpm-macros, which is great! I’ll save the full re-review until you have a chance to read my feedback on the patch, but here’s what I see at a glance: - Can drop BuildRequires: pyproject-rpm-macros since python3-devel now depends on it - Can drop BuildRequires: python3dist(wheel) BuildRequires: python3dist(pytest-runner) BuildRequires: python3dist(tox-current-env) since they will be generated—wheel always with %pyproject_buildrequires, tox-current-env when using %pyproject_buildrequires, and pytest-runner as a consequence of it being added (strangely) to setup_requires in setup.py once you apply the patch(es) as described in my previous comments. - Change %files to %files -f %{pyproject_files} and remove %{python3_sitelib}/parsimonious-%{version}.dist-info/ %{python3_sitelib}/parsimonious/ - In many cases, you can remove %license LICENSE too, but you need to verify the license file in dist-info is marked using something like “rpm -qL -p /path/to/built/python3-foo.whatever.rpm”, since there are exceptions. https://pagure.io/packaging-committee/issue/1145 Leaving it in is not harmful. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2036758 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
