https://bugzilla.redhat.com/show_bug.cgi?id=2038144 --- Comment #3 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > %define AppProgram vttest Should be removed. Always use standard %{name} macro. > %define AppVersion 2.7.%{AppPatched} Always use standard %{version} macro. > Release: 1 Missing %{?dist} tag: Release: 1%{?dist} > # no need for debugging symbols... > %define debug_package %{nil} Must be removed. All Fedora packages with ELF binaries must have automatically generated -debuginfo subpackages. > %setup -q -n %{AppProgram}-%{AppPatched} Can be simplified after fixing version and release: %autosetup > INSTALL_PROGRAM='${INSTALL}' \ > %configure \ > --target %{_target_platform} \ > --prefix=%{_prefix} \ > --bindir=%{_bindir} \ > --libdir=%{_libdir} \ > --mandir=%{_mandir} Should be simplified by %configure. All needed flags will be added automatically. > [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT Must be removed. Not allowed on Fedora. > make install DESTDIR=$RPM_BUILD_ROOT Should be replaced with %make_install. > strip $RPM_BUILD_ROOT%{_bindir}/%{AppProgram} Must be removed. Stripping will be performed automatically to the separate -debuginfo subpackage. > %defattr(-,root,root) Must be removed. Not allowed on Fedora. > %{_prefix}/bin/%{AppProgram} Must be replaced with: %{_bindir}/%{name} > %{_mandir}/man1/%{AppProgram}.* %{_mandir}/man1/%{name}.* > # each patch should add its ChangeLog entries here Remove this entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2038144 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
