https://bugzilla.redhat.com/show_bug.cgi?id=2038135 --- Comment #5 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > %define AppProgram luit > %define UseProgram %{AppProgram} Should be removed. Always use standard %{name} macro. > %define AppVersion 20210218 Maybe you should replace version 2.0 with this? > Version: 2.0+%{AppVersion} Version tag is incorrect. You must follow Versioning guidelines for snapshots: https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots > Requires: zlib Must be removed. rpmbuild will automatically find out and add all runtime dependencies. > %define debug_package %{nil} Must be removed. All Fedora packages with ELF binaries must have automatically generated -debuginfo subpackages. > %setup -q -n %{AppProgram}-%{AppVersion} Can be replaced with: %autosetup -n %{name}-%{AppVersion} Also the following build requirements must be added: BuildRequires: automake BuildRequires: gcc BuildRequires: make > make Should be replaced with %make_build. > [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT Must be removed. Not allowed on Fedora. > make install DESTDIR=$RPM_BUILD_ROOT Should be replaced with %make_install. > strip $RPM_BUILD_ROOT%{_bindir}/%{UseProgram} Must be removed. Stripping will be performed automatically to the separate -debuginfo subpackage. > %defattr(-,root,root) Must be removed. Not allowed on Fedora. > %{_prefix}/bin/%{UseProgram} Must be replaced with: %{_bindir}/%{name} > %{_mandir}/man1/%{UseProgram}.* %{_mandir}/man1/%{name}.* > # each patch should add its ChangeLog entries here Remove this entry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2038135 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
