https://bugzilla.redhat.com/show_bug.cgi?id=1988840 --- Comment #2 from Christopher Crouse <mail@xxxxxxxxx> --- Hi Davide, I have a few suggestions: === [1] I would update the package name to match the parent `boost` package, in the format: boost-%{child}, since it depends on boost. For example: `boost-http-server`. [2] I would recommend adding the upstream PR URL link in the spec's `Patch0` comment, since I noticed the difference between the PR and actual patch being applied. [3] The doc sub package contains one file with the MIT license. ... MIT License ----------- BoostHttpServer-4bc36235fb60a0db20ff4b722ff1136acde4651d/docs/jquery.js ... [4] Personal preference, adding a newline to the *BuildRequires* section, separating the `*-devel` from the other build dependencies, for example: ... BuildRequires: doxygen BuildRequires: gcc-c++ BuildRequires: make BuildRequires: sed BuildRequires: boost-devel BuildRequires: CTML-devel ... === -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1988840 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
