[Bug 1913980] Review Request: iso-country-flags - Country flags images

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1913980



--- Comment #5 from Eugene A. Pivnev <ti.eugene@xxxxxxxxx> ---
(In reply to Robert-André Mauchin 🐧 from comment #4)
>  - Typo here:
> 
> %global gitowner gosquaredg
> 
> Should be
> 
> %global gitowner gosquared

Fixed.

>  - You need to add the shortcommit: and release should start at 0.1 for
> prelease:
> 
> Release:	0.1.20170202git%{shortcommit}%{?dist}

Fixed.

> * Sat Jan 30 2021 TI_Eugene <ti.eugene@xxxxxxxxx> 0-0.1.20170202git1d382a9

Fixed.

>  - Should be .tar.gz here:
> 
> Source0:
> https://github.com/%{gitowner}/%{gitproject}/archive/%{commit}/%{name}-
> %{shortcommit}.tar.gz

Fixed.

Spec:
https://tieugene.fedorapeople.org/rpms/iso-country-flags/iso-country-flags.spec
SRPM:
https://tieugene.fedorapeople.org/rpms/iso-country-flags/iso-country-flags-0-0.1.20170202git1d382a9.fc35.src.rpm
Koji builds (just oldest and newest):
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=80961829
F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=80961896


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1913980
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux