[Bug 2037645] Review Request: Cantera - Chemical kinetics, thermodynamics, and transport tool suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2037645



--- Comment #18 from José Matos <jamatos@xxxxxxxx> ---
(In reply to Mark E. Fuller from comment #17)
> Thanks for all the advice - this is extremely helpful.
> Also sorry for the delay - it's the weekend in Israel.

There is no problem, Shabbat Shalom. :-)

> Latest koji scratch build with the suggested modifications is at
> https://koji.fedoraproject.org/koji/taskinfo?taskID=80951521
> As you can see, arch s390x, x86_64, ppc64le and aarch64 all failed while
> i686 and armv7hl successfully built.
> All failures were due to the same error as above; adding the
> prefix=%{_prefix} to the scons install call had no effect

I think that you found the culprit. The architectures that failed are where lib
is lib64.
>From that I suspect that there is some heuristics this is going astray with
scons 4.3.

Also for an aesthetic point of view I suggest that the definition of %scons is
placed near BuildRequires part.

Regarding scons remember that in order to work in RHEL you should use now
%scons (that it will take care of the distinction).
Also to work around this bug in the installer I suggestion the following code
that works in all cases:

%install
%scons install prefix=%{_prefix} libdirname=%{_lib} stage_dir=%{buildroot}
# work around a bug in the installer:
https://github.com/Cantera/cantera/issues/1149
if [ ! -f %{buildroot}%{_prefix}/bin/ck2cti ]; then
  mv %{buildroot}%{_prefix}/local/bin/* %{buildroot}%{_prefix}/bin
fi

With this code the package builds in x86_64 for both F35 and rawhide and so it
should for all the other architectures.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2037645
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux